Page 1 of 1

Build 2971 - viewer rewrite

Posted: Sat May 18, 2019 5:32 pm
by mike
Hi folks,

Here's the first preview build of v1.2.6. During these months I managed to perform some significant internal cleanups and refactorings, which hopefully will make maintenance and support easier in the future.

So, what's new at the moment:
  • The Internal Viewer was rewritten almost entirely. For a long time I was frustrated about the existed one due to how badly it was designed, that made small but steady improvements almost impossible to do. Also it heavily relied on Cocoa's text layout manager, which resulted in abysmal layout performance. The new implementation is much faster, properly decoupled, has unit tests and is much more malleable to change if needed. Some immediate improvements are in hotkeys support:
    - cmd+1: toggle text mode
    - cmd+2: toggle hex mode
    - cmd+3: toggle preview mode
    - cmd+0: show options popup
    - cmd+L: show ‘go to’ popup
    Go To popup now has an option to jump to an offset(^2) in addition to a percentage(^1).
    There might still be some rough edges in the new implementation which will be polished later in this version.
  • Find Files sheet got an option to search for files not containing some text.
  • Dragging items to the Trash Bin now deletes them as expected.
  • New action - “Copy Item Directory”: shift+alt+cmd+c.
  • Popup menus (F1/F2 and quick lists: cmd+1..5) can now switch to other menus by hitting their hotkeys. For instance, when the F1 menu is shown, a hit on F2 will close the current menu and show a new one. This feature requires 10.13+.
  • Fixed an issue with an invalid placing of sharing popup (like Add People when sharing a document from iCloud Drive).
  • Fixed a visual glitch: Preferences->Tools parameters menu didn't get a proper appearance.
Here's the link to the preview build: ... (2971).zip

As always, your feedback is welcome!


Re: Build 2971 - viewer rewrite

Posted: Mon May 20, 2019 1:50 pm
by darek
Oh man... Viewer was definitely the weakest part of Nimble Commander. It was lagging on larger files and often not very reliable, taking few tries to open a file, especially on remote connections.

But now... I'm LOVING it. From a quick check the new version looks very snappy and perfectly reliable. I also like the shortcuts to switch between modes. Wonderful! I've already switched to the preview build full time and I'll let you know if I notice any rough spots.

Re: Build 2971 - viewer rewrite

Posted: Tue May 21, 2019 1:09 am
by athan
Thank you for the great job Mike!
Glad to see this superb project is still alive.👍

Re: Build 2971 - viewer rewrite

Posted: Fri Jun 07, 2019 5:51 am
by d0ublezer0
very cool
- cmd+L: show ‘go to’ popup
cannot be overridden to cmd+G ?

Re: Build 2971 - viewer rewrite

Posted: Fri Jun 07, 2019 6:39 pm
by mike
d0ublezer0 wrote:
Fri Jun 07, 2019 5:51 am
- cmd+L: show ‘go to’ popup
cannot be overridden to cmd+G ?
It can be overridden manually in Preferences->Hotkeys, but this would block the default Cmd+G action, which is "Find Next" and is also used by Viewer.