find files dialog

Any wishes
d0ublezer0
Posts: 90
Joined: Tue Jun 28, 2016 6:17 pm
Location: NN, Russia

find files dialog

Post by d0ublezer0 » Sun Feb 19, 2017 8:55 am

suggestions:
please add keyboard shortcut to view button in file find results, for example - spacebar

also you can add F4 as edit shortcut without going to panel with results for quick editing (as in TC)

and final one: maybe it is not necessary to clear the previous search results?

d0ublezer0
Posts: 90
Joined: Tue Jun 28, 2016 6:17 pm
Location: NN, Russia

Re: find files dialog

Post by d0ublezer0 » Sun Feb 19, 2017 9:07 am

Even for me was strange, view graphic file as text after pressing [preview] button
Image

User avatar
mike
Posts: 807
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: find files dialog

Post by mike » Sun Feb 19, 2017 9:31 am

d0ublezer0 wrote:
Sun Feb 19, 2017 8:55 am
suggestions:
please add keyboard shortcut to view button in file find results, for example - spacebar
This one is simple - there's already a ^V hotkey for this.
d0ublezer0 wrote:
Sun Feb 19, 2017 8:55 am
also you can add F4 as edit shortcut without going to panel with results for quick editing (as in TC)
Yep, I have this one in backlog, will be done at some point.
d0ublezer0 wrote:
Sun Feb 19, 2017 8:55 am
and final one: maybe it is not necessary to clear the previous search results?
Well, it'll all about VFS management at this moment.
Simply storing some list of found items would lead to preservation of their VFS'es, which will lead to expected results in form of some network connections, opened file handles, memory usage et cetera.
It's possible to convert found items list into some meta-information for later restoration, but such fiddling is not a simple task, and might lead to very funky edge cases.
So, in short, it's good to save those results, but it's tricky to implement it.
d0ublezer0 wrote:
Sun Feb 19, 2017 9:07 am
Even for me was strange, view graphic file as text after pressing [preview] button
Actually Preview is not participating in choosing of viewer's initial state, it's only between Text and Hex now.

d0ublezer0
Posts: 90
Joined: Tue Jun 28, 2016 6:17 pm
Location: NN, Russia

Re: find files dialog

Post by d0ublezer0 » Sun Feb 19, 2017 9:37 am

mike wrote:
Sun Feb 19, 2017 9:31 am
This one is simple - there's already a ^V hotkey for this.
Spacebar functions as the default preview shortcut in the whole MacOS system. When navigating through the file panels in NC - the same thing. It would be logical to use the same key at results window, without introducing a new keyboard shortcut.

User avatar
mike
Posts: 807
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: find files dialog

Post by mike » Sun Feb 19, 2017 10:31 am

Ok, agree, it seems reasonable to process Spacebar as View when focus is on results list.
But it can't be wired as a dialog-wide hotkey, since buttons use it to trigger themselves.

d0ublezer0
Posts: 90
Joined: Tue Jun 28, 2016 6:17 pm
Location: NN, Russia

Re: find files dialog

Post by d0ublezer0 » Sun Feb 19, 2017 5:35 pm

This behavior is only required when selected entry in the results list.

User avatar
mike
Posts: 807
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: find files dialog

Post by mike » Mon Feb 20, 2017 2:58 am

Ok, done.

d0ublezer0
Posts: 90
Joined: Tue Jun 28, 2016 6:17 pm
Location: NN, Russia

Re: find files dialog

Post by d0ublezer0 » Sun Feb 26, 2017 12:19 pm

just found:
Image
when selected encoding dropdown [tab] or [shift]+[tab] not working

User avatar
mike
Posts: 807
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: find files dialog

Post by mike » Mon Feb 27, 2017 4:40 am

d0ublezer0 wrote:
Sun Feb 26, 2017 12:19 pm
just found:
when selected encoding dropdown [tab] or [shift]+[tab] not working
I can't reproduce this issue. Can please re-check it on a recent build?

d0ublezer0
Posts: 90
Joined: Tue Jun 28, 2016 6:17 pm
Location: NN, Russia

Re: find files dialog

Post by d0ublezer0 » Mon Feb 27, 2017 8:12 pm

2076
pressing [tab] on focused dropdown - nothing happened

Post Reply