Crash when previewing images in archives/over SFTP [FIXED]

Questions, glitches, bugs and crashes
Post Reply
fulgger
Posts: 3
Joined: Wed Jan 06, 2021 12:26 pm

Crash when previewing images in archives/over SFTP [FIXED]

Post by fulgger » Wed Jan 06, 2021 12:35 pm

Hi there,

Ever since I've installed (1.2.9, build 3524, running on Catalina 10.15.7) I've had issues with previewing images over SFTP - NC just crashes each and every time I try doing that.

Today I've noticed the same behavior with images in zip files, again sudden crashes. They happen both if I press `Space` to preview the files, or View them with `F3, and change the mode to Preview. Needless to say, any of this didn't happen with the previous version.

I've attached the crash log, hopefully this will help debug the issue.

Thanks for continuing to maintain NC, it makes the Mac experience so much better.

Update: this happens when previewing zipped .txt files too (such as the one attached), assuming it happens whenever one tries to preview zipped data.
Attachments
NCCrashLog.txt.zip
(25.24 KiB) Downloaded 3 times

User avatar
mike
Posts: 857
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: Crash when previewing images in archives/over SFTP

Post by mike » Wed Jan 06, 2021 10:49 pm

Hi fulgger, thank you for the report.
I can reproduce the issue on my side on Catalina/x64, will try to fix it ASAP, as time permits.
The issue is indeed somewhere in the glue code between VFS and QuickLook, i.e. it doesn't matter which VFS is used.

fulgger
Posts: 3
Joined: Wed Jan 06, 2021 12:26 pm

Re: Crash when previewing images in archives/over SFTP

Post by fulgger » Thu Jan 07, 2021 7:58 am

Thanks mike, no rush!

User avatar
mike
Posts: 857
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: Crash when previewing images in archives/over SFTP

Post by mike » Thu Jan 07, 2021 10:39 pm

Well, I found and fixed the root cause in this particular case.
The cause was, by the looks of it, a stack overflow/corruption by a 256KB buffer placed on the stack in a code that wasn't touched in two years.
What actually happens (and why it works fine on BigSur/ARM64) is still a bit unclear to me, but seems to be a combination of a toolchain change and more aggressive optimisation levels.
I'll try to better understand the mechanics of the problem and look for similar potential issues before pushing an update.
Hopefully this weekend v1.2.9 will receive a fresh build.

User avatar
mike
Posts: 857
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: Crash when previewing images in archives/over SFTP

Post by mike » Sun Jan 10, 2021 10:38 pm

Updated v1.2.9 to build 3532, please pull this one via auto-update or manually.

fulgger
Posts: 3
Joined: Wed Jan 06, 2021 12:26 pm

Re: Crash when previewing images in archives/over SFTP [FIXED]

Post by fulgger » Mon Jan 11, 2021 7:13 am

Thanks for being so prompt mike! I've pulled the latest version and can confirm that it doesn't crash when previewing zipped files or files over SFTP anymore.

Cheers!

Post Reply