Build 3308 - Improvements in the built-in terminal

Alpha/Beta versions for early access to new half-cooked features
buzy
Posts: 14
Joined: Thu Dec 10, 2020 7:14 pm

Re: Build 3308 - Improvements in the built-in terminal

Post by buzy » Sat Jan 30, 2021 10:55 am

Sounds great. Thanks!

mikej
Posts: 2
Joined: Wed Apr 27, 2022 6:05 am

Re: Build 3308 - Improvements in the built-in terminal

Post by mikej » Mon May 09, 2022 2:10 pm

Hi Mike. I'm on build Version 1.4.0 (3777) using zsh via Homebrew and am running into a similar issue to the one that a few people described earlier in this thread (Terminal just displays a black window with a cursor, does not respond to any inputs).

When I use the option for "Open Shell with Default login shell" I can see an error in the debug log output:

Code: Select all

[2022-05-09 15:06:39.274] [term] [info] [ShellTask.cpp:258] Starting a new shell: "/usr/local/bin/zsh"
[2022-05-09 15:06:39.274] [term] [info] [ShellTask.cpp:260] "/usr/local/bin/zsh" -> "../Cellar/zsh/5.8/bin/zsh"
[2022-05-09 15:06:39.274] [term] [info] [ShellTask.cpp:261] Initial work directory: /Users/mike/
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:265] Environment:
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	LANG = en_GB.UTF-8
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	LC_COLLATE = en_GB.UTF-8
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	LC_CTYPE = en_GB.UTF-8
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	LC_MESSAGES = en_GB.UTF-8
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	LC_MONETARY = en_GB.UTF-8
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	LC_NUMERIC = en_GB.UTF-8
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	LC_TIME = en_GB.UTF-8
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	TERM = xterm-16color
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:267] 	TERM_PROGRAM = Nimble_Commander
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:275] posix_openpt(O_RDWR) returned 50 (master_fd)
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:298] ptsname: /dev/ttys002
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:306] slave_fd: 51
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:365] cwd_pipe: 52, 53
[2022-05-09 15:06:39.274] [term] [debug] [ShellTask.cpp:366] semaphore_pipe: 54, 55
[2022-05-09 15:06:39.282] [term] [debug] [ShellTask.cpp:383] fork() returned 7831
[2022-05-09 15:06:39.287] [term] [warning] [ShellTask.cpp:396] forked process failed to become a shell!
It's a little bit odd, because from the log it does seem like Nimble Commander is now following the symlink.

However, if I switch to the "Open shell with Command" option and paste in the actual path to zsh e.g. /usr/local/Cellar/zsh/5.8/bin/zsh then the terminal works fine. However, doing this would mean I have to remember to update the setting in Nimble Commander whenever there's an updated zsh in Homebrew.

Can you see any other clues in the logs as to what might be happening here? Or anything else I can try to help debug this?

Thanks!

User avatar
mike
Posts: 985
Joined: Thu Jul 16, 2015 5:35 am
Location: Exeter, UK

Re: Build 3308 - Improvements in the built-in terminal

Post by mike » Sat May 14, 2022 11:35 am

mikej wrote:
Mon May 09, 2022 2:10 pm
Hi Mike. I'm on build Version 1.4.0 (3777) using zsh via Homebrew and am running into a similar issue to the one that a few people described earlier in this thread (Terminal just displays a black window with a cursor, does not respond to any inputs).
[...]
It's a little bit odd, because from the log it does seem like Nimble Commander is now following the symlink.

However, if I switch to the "Open shell with Command" option and paste in the actual path to zsh e.g. /usr/local/Cellar/zsh/5.8/bin/zsh then the terminal works fine. However, doing this would mean I have to remember to update the setting in Nimble Commander whenever there's an updated zsh in Homebrew.

Can you see any other clues in the logs as to what might be happening here? Or anything else I can try to help debug this?

Thanks!
Hi mikej,

Thanks for sharing the log files, the issue was that NC didn't support relative symlinks when resolving a real path to a shell image (it only supported absolute paths).
I've fixed the issue, so now it does and specifying e.g. "/usr/local/bin/zsh" works as expected.
The next build will contain this bug fix.

Regards,
Mike

mikej
Posts: 2
Joined: Wed Apr 27, 2022 6:05 am

Re: Build 3308 - Improvements in the built-in terminal

Post by mikej » Mon May 16, 2022 7:31 am

Hi Mike. Thanks for taking a look into this, and glad the logs were helpful. I'll do a workaround for now and keep an eye out for the next build.

Cheers!

Post Reply